Consolidate review feedback from PRs #26 and #6 into single mergeable change#38
Closed
Copilot wants to merge 4 commits intocopilot/setup-copilot-instructionsfrom
Closed
Conversation
Co-authored-by: groupthinking <154503486+groupthinking@users.noreply.github.com>
PR #26 fixes (with review feedback incorporated): - Redirect console.log to stderr for MCP stdout (unknown[] type) - Use URLSearchParams for mentions URL + wire up since_id - Add Array.isArray() guard in fetchThread - Copy tweets array before sorting + unknown type in parseThread - Cap processedMentions with safe {value, done} iterator - Process mentions oldest-first for chronological pruning PR #6 fix (with review feedback): - Add mentionPostId param to analyzeAndDecide for reply targeting - Replace any type with specific type in Grok response parsing Co-authored-by: groupthinking <154503486+groupthinking@users.noreply.github.com>
Co-authored-by: groupthinking <154503486+groupthinking@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Implement suggestions and correct errors in pending PRs
Consolidate review feedback from PRs #26 and #6 into single mergeable change
Feb 9, 2026
Owner
|
Closing stale draft — superseded by cleanup/ready-to-use merge to main |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Multiple open PRs had unresolved review comments blocking merge. This consolidates the two substantive PRs (#26: runtime bug fixes, #6: reply targeting) with all reviewer feedback applied.
PR #26 — Runtime bug fixes + review feedback
console.log→stderrto avoid corrupting MCP StdioServerTransport protocol messages. Usesunknown[]per reviewer.lastMentionIdwithURLSearchParams(reviewer suggestion) to avoid refetching processed mentions each poll cycle.Array.isArray(response.data)before callingparseThread— prevents crash on unexpected API shapes.[...tweets].sort()instead of in-place mutation.parseThreadsignature narrowed fromany→unknown.processedMentionsSet at 10k, prune with safe{ value, done }iterator (not type assertion). Process mentions oldest-first so Set insertion order is chronological and pruning evicts correctly.PR #6 — Reply targeting fix + review feedback
mentionPostIdparam toanalyzeAndDecide()— replies now target the specific mention post instead of always targetingthread.root_post.id.anywith typed interface for Grok API response parsing.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.